revert regex change

JuliaLang · Oct 21, 2024 · 3163a6c · 3163a6c
1 parent 578c7b9
commit 3163a6c
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 10 deletions.
diff --git a/stdlib/REPL/src/REPLCompletions.jl b/stdlib/REPL/src/REPLCompletions.jl
@@ -1229,8 +1229,7 @@ function completions(string::String, pos::Int, context_module::Module=Main, shif
         # ?(x, y)TAB lists methods you can call with these objects
         # ?(x, y TAB lists methods that take these objects as the first two arguments
         # MyModule.?(x, y)TAB restricts the search to names in MyModule
-        # but ignore ?( inside strings
-        rexm = match(r"^(?!\")(?:\w+\.|)\?\((.*)$", partial)
+        rexm = match(r"(\w+\.|)\?\((.*)$", partial)
         if rexm !== nothing
             # Get the module scope
             if isempty(rexm.captures[1])

diff --git a/stdlib/REPL/test/replcompletions.jl b/stdlib/REPL/test/replcompletions.jl
@@ -768,14 +768,6 @@ end
 # https://github.com/JuliaLang/julia/issues/52551
 @test !isempty(test_complete("?("))
 
-# issue #56272: Ignore ?( in strings
-@test isempty(test_complete("\"?(\""))
-@test isempty(test_complete("\"foo?(\""))
-@test isempty(test_complete("\"?(foo\""))
-@test isempty(test_complete("\"\"\"?(\"\"\""))
-@test isempty(test_complete("\"\"\"foo?(\"\"\""))
-@test isempty(test_complete("\"\"\"?(foo\"\"\""))
-
 #################################################################
 
 # Test method completion with varargs