Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch PATH_cache_finished to Threads.Condition #52892

Closed
wants to merge 1 commit into from

Conversation

ericphanson
Copy link
Contributor

fixes #52890

Seems to work locally for me, though I'm not sure if this is the right fix

@IanButterworth
Copy link
Member

This should be the fix #52893

@IanButterworth
Copy link
Member

IanButterworth commented Jan 13, 2024

I'm going to close this as superseded, and I think tests are just going to hang

@ericphanson ericphanson deleted the eph/fix-condition branch January 13, 2024 20:05
@ericphanson
Copy link
Contributor Author

They ran ok locally fwiw

@IanButterworth
Copy link
Member

Huh.. how did both tasks acquire the lock?

@ericphanson
Copy link
Contributor Author

wait releases it:

help?> Threads.Condition
  Threads.Condition([lock])

  A thread-safe version of Base.Condition.

  To call wait or notify on a Threads.Condition, you must first call lock on it. When wait is called, the lock is atomically released during
  blocking, and will be reacquired before wait returns. Therefore idiomatic use of a Threads.Condition c looks like the following:

@IanButterworth
Copy link
Member

My bad. Ok I'll update my PR. There are other fixes to make too based on Jameson's review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ConcurrencyViolationError("lock must be held") during repl shell completions
2 participants