Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention use of StyledStrings in Logging in NEWS #54301

Closed

Conversation

tecosaur
Copy link
Contributor

Just seems like something worth adding in the wake of #51802 and #51829.

@KristofferC
Copy link
Member

KristofferC commented Apr 29, 2024

#52075 has to be fixed though and unless the rendering of StyledStrings is moved into Base I think the StyledStrings usage has to be reverted so we can move ConsoleLogger into Base?

@tecosaur
Copy link
Contributor Author

I thought the fix being explored was #53660?

@KristofferC
Copy link
Member

Putting Logging back into the sysimage is not a fix.

@tecosaur
Copy link
Contributor Author

Well, I'm referring to #53660 (comment) in particular.

@KristofferC
Copy link
Member

KristofferC commented May 13, 2024

Got reverted on 1.11 to fix regressions in the logging colors when Logging was not loaded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants