Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make
memorynew
intrinsic #55913base: master
Are you sure you want to change the base?
make
memorynew
intrinsic #55913Changes from 24 commits
53616ec
81755e6
cb79529
7b6d78e
e3d60b6
4b9c7b3
a9b4fae
933770b
c18b684
86a7ba9
21be744
3d614f0
80c58b6
5d1051a
4094ae9
38f262c
2ff0656
7e32bef
516a702
8631d2a
9dcaf13
311f5ef
59d0d2f
db95887
94f569a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we just make this the bootstrap method too? The boundscheck macro is just expanded simply to
@_boundscheck &&
, so this seems compatibleThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds reasonable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should probably also check that it is a GenericMemory subtype
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This arithmetic appears to be unsigned, while the overflow itself is supposed to be a signed check (or multiply elsz by 2 for the same effect) also may be missing the final
overflow |= __builtin_add_overflow_p(nbytes, 1, 1)
call to convert the condition < MAXINT into an overflow test