Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make remaining float intrinsics require float arguments #57398

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Make remaining float intrinsics require float arguments #57398

wants to merge 7 commits into from
+154 −81

Conversation

xal-0
Copy link
Contributor

@xal-0 xal-0 commented Feb 13, 2025

The fptrunc/fpext intrinsics were modified in #57160 to throw on non-float arguments.

  • The arithmetic and math float intrinsics now require all their arguments to be floats
  • fptosi/fptoui require their source to be a float
  • sitofp/uitofp require their destination type to be a float

Also fixes #57384.

@xal-0 xal-0 force-pushed the strict-float-intrinsics branch from b2bfc59 to 4eb0368 Compare February 13, 2025 21:21
@xal-0 xal-0 marked this pull request as draft February 13, 2025 21:43
@xal-0 xal-0 force-pushed the strict-float-intrinsics branch from 0dce3a3 to 1bd20ce Compare February 14, 2025 00:16
@xal-0 xal-0 marked this pull request as ready for review February 14, 2025 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oscardssmith oscardssmith oscardssmith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Runtime intrinsics: fptoui/fptosi have inconsistent rounding behaviour
2 participants
@xal-0 @oscardssmith