loading: More simplification #59881
Open
loading: More simplification #59881
+93
−81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depending on how ambitious you are with the code loading stuff, https://github.com/JuliaLang/julia/pull/46690/files#diff-f942a392247abcb2375398f5285fac6411894ac16fc4d0153c3ac16b0ef7eb71 might be of interest. |
Mostly unswitches the distinction between a top-level load and a load into another project. The hope is that by keeping the code load flow more linear, it becomes easier to follow. No behavioral changes intended.
Keno
force-pushed
the
kf/loadingcleanup2
branch
from
2181fd0 to
5f4f7ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly unswitches the distinction between a top-level load and a load into another project. The hope is that by keeping the code load flow more linear, it becomes easier to follow. No behavioral changes intended.