-
Notifications
You must be signed in to change notification settings - Fork 3
Upgrade BLISBLAS.jl #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6 +/- ##
==========================================
+ Coverage 91.66% 95.00% +3.33%
==========================================
Files 1 1
Lines 12 20 +8
==========================================
+ Hits 11 19 +8
Misses 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@carstenbauer
|
|
Haven't reviewed this yet but note that almost all CI runs are failing. Can you address those failures first? |
The issues seem related to blis. Since the OpenBLAS backend wasn't cleared, blis symbols were never used. It turns out that using |
|
We just merged BLIS 2.0 into Yggdrasil, so can this PR be revived and updated to allow BLIS 2.0? |
|
It should be straightforward to rebase this on main now. I am now requiring Julia 1.12 to keep things simple (and perhaps it provides a good starting point to make things work on older versions). If we enable LAPACK now, we should be able to use the stock tests from LinearAlgebra (and delete the modified tests from LinearAlgebra I just checked in). |
|
We should be able to tag the 0.2 release after this PR is merged. |
ea6f297 to
91e21e3
Compare
91e21e3 to
e7b4420
Compare
|
@ViralBShah I rebased the PR. |
|
I think the test failures here are actually due to a bug in LBT - |
Co-authored-by: Ian McInerney <mcianster@gmail.com>
|
@amontoison Should we register a new release or are there other things we should do before that? |
|
We can register a new release. |
|
Registered, along with a few more improvements. Verified this all works with Julia 1.9 onwards. |
@carstenbauer
I compiled an LP64 version of BLIS with Yggdrasil.
With Julia 1.9, we should be able to combine them with
LAPACK_jllandLAPACK32_jll.