Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't load packages in extension other than parent #217

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions ext/LinearMapsSparseArraysExt.jl
Original file line number Diff line number Diff line change
Expand Up @@ -3,20 +3,21 @@ module LinearMapsSparseArraysExt
import SparseArrays: sparse, blockdiag, SparseMatrixCSC
using SparseArrays: AbstractSparseMatrix

using LinearAlgebra, LinearMaps
using LinearMaps
import LinearMaps: _issymmetric, _ishermitian
using LinearMaps: WrappedMap, CompositeMap, LinearCombination, ScaledMap, UniformScalingMap,
AdjointMap, TransposeMap, BlockMap, BlockDiagonalMap, KroneckerMap, KroneckerSumMap,
VecOrMatMap, AbstractVecOrMatOrQ, MapOrVecOrMat
using LinearMaps: convert_to_lmaps, _tail, _unsafe_mul!
VecOrMatMap, AbstractVecOrMatOrQ, MapOrVecOrMat, convert_to_lmaps, _tail, _unsafe_mul!

using LinearMaps.LinearAlgebra

_issymmetric(A::AbstractSparseMatrix) = issymmetric(A)
_ishermitian(A::AbstractSparseMatrix) = ishermitian(A)

# blockdiagonal concatenation via extension of blockdiag

"""
blockdiag(As::Union{LinearMap,AbstractVecOrMatOrQ}...)::BlockDiagonalMap
blockdiag(As::Union{LinearMap,AbstractVecOrMat,AbstractQ}...)::BlockDiagonalMap

Construct a (lazy) representation of the diagonal concatenation of the arguments.
To avoid fallback to the generic `blockdiag`, there must be a `LinearMap`
Expand Down
Loading