Fix SPDs

JuliaManifolds · Sep 23, 2023 · 05fcff8 · 05fcff8
1 parent 5d4491c
commit 05fcff8
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/src/manifolds/PositiveNumbers.jl b/src/manifolds/PositiveNumbers.jl
@@ -298,12 +298,7 @@ function Random.rand(M::PositiveNumbers; kwargs...)
     return rand(Random.default_rng(), M; kwargs...)
 end
 
-function Random.rand(
-    rng::AbstractRNG,
-    ::PositiveNumbers;
-    σ=1.0,
-    vector_at=nothing,
-)
+function Random.rand(rng::AbstractRNG, ::PositiveNumbers; σ=1.0, vector_at=nothing)
     if vector_at === nothing
         return exp(randn(rng) * σ)
     else
@@ -312,7 +307,6 @@ function Random.rand(
     return pX
 end
 
-
 function Random.rand!(
     rng::AbstractRNG,
     ::PositiveNumbers,

diff --git a/src/manifolds/SymmetricPositiveDefinite.jl b/src/manifolds/SymmetricPositiveDefinite.jl
@@ -403,6 +403,10 @@ Generate a random symmetric positive definite matrix on the
 """
 rand(M::SymmetricPositiveDefinite; σ::Real=1)
 
+function allocate_result(M::SymmetricPositiveDefinite, ::typeof(Random.rand), p::SPDPoint)
+    return zero_vector(M, p)
+end
+
 function Random.rand!(
     rng::AbstractRNG,
     M::SymmetricPositiveDefinite{N},