Skip to content

Commit

Permalink
optimized defaults for inverse_translate_diff! of groups with left-in…
Browse files Browse the repository at this point in the history
…variant storage
  • Loading branch information
mateuszbaran committed Aug 23, 2024
1 parent 4794c69 commit 0c5d162
Show file tree
Hide file tree
Showing 2 changed files with 45 additions and 1 deletion.
2 changes: 1 addition & 1 deletion NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [0.10.0]unreleased
## [0.10.0]2024-08-24

### Changed

Expand Down
44 changes: 44 additions & 0 deletions src/groups/group.jl
Original file line number Diff line number Diff line change
Expand Up @@ -1081,6 +1081,50 @@ function inverse_translate_diff!(
BG = base_group(G)
return translate_diff!(BG, Y, inv(BG, p), q, X, conv)
end
function inverse_translate_diff!(

Check warning on line 1084 in src/groups/group.jl

View check run for this annotation

Codecov / codecov/patch

src/groups/group.jl#L1084

Added line #L1084 was not covered by tests
::TraitList{<:IsGroupManifold{<:AbstractGroupOperation,LeftInvariantRepresentation}},
G::AbstractDecoratorManifold,
Y,
::Any,
::Any,
X,
::LeftForwardAction,
)
return copyto!(G, Y, X)

Check warning on line 1093 in src/groups/group.jl

View check run for this annotation

Codecov / codecov/patch

src/groups/group.jl#L1093

Added line #L1093 was not covered by tests
end
function inverse_translate_diff!(

Check warning on line 1095 in src/groups/group.jl

View check run for this annotation

Codecov / codecov/patch

src/groups/group.jl#L1095

Added line #L1095 was not covered by tests
::TraitList{<:IsGroupManifold{<:AbstractGroupOperation,LeftInvariantRepresentation}},
G::AbstractDecoratorManifold,
Y,
::Any,
::Any,
X,
::RightForwardAction,
)
return copyto!(G, Y, X)

Check warning on line 1104 in src/groups/group.jl

View check run for this annotation

Codecov / codecov/patch

src/groups/group.jl#L1104

Added line #L1104 was not covered by tests
end
function inverse_translate_diff!(

Check warning on line 1106 in src/groups/group.jl

View check run for this annotation

Codecov / codecov/patch

src/groups/group.jl#L1106

Added line #L1106 was not covered by tests
::TraitList{<:IsGroupManifold{<:AbstractGroupOperation,LeftInvariantRepresentation}},
G::AbstractDecoratorManifold,
Y,
p,
::Any,
X,
::LeftBackwardAction,
)
return adjoint_action!(G, Y, p, X, RightAction())

Check warning on line 1115 in src/groups/group.jl

View check run for this annotation

Codecov / codecov/patch

src/groups/group.jl#L1115

Added line #L1115 was not covered by tests
end
function inverse_translate_diff!(

Check warning on line 1117 in src/groups/group.jl

View check run for this annotation

Codecov / codecov/patch

src/groups/group.jl#L1117

Added line #L1117 was not covered by tests
::TraitList{<:IsGroupManifold{<:AbstractGroupOperation,LeftInvariantRepresentation}},
G::AbstractDecoratorManifold,
Y,
p,
::Any,
X,
::RightBackwardAction,
)
return adjoint_action!(G, Y, p, X, LeftAction())

Check warning on line 1126 in src/groups/group.jl

View check run for this annotation

Codecov / codecov/patch

src/groups/group.jl#L1126

Added line #L1126 was not covered by tests
end

"""
log_inv(G::AbstractManifold, p, q)
Expand Down

0 comments on commit 0c5d162

Please sign in to comment.