Skip to content

Commit

Permalink
Remove more deprecated things
Browse files Browse the repository at this point in the history
  • Loading branch information
mateuszbaran committed Aug 21, 2024
1 parent b71d4d4 commit b2df4a0
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 16 deletions.
2 changes: 2 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
* `ExtrinsicEstimation()` (should be replaced with `ExtrinsicEstimation(EfficientEstimator())`),
* `Symplectic` (renamed to `SymplecticMatrices`),
* `SymplecticMatrix` (renamed to `SymplecticElement`).
* `AbstractEstimationMethod` (renamed to `AbstractApproximationMethod`).
* `VectorBundleVectorTransport` (renamed to `FiberBundleProductVectorTransport`).
* `rand` on `SymplecticMatrices` and `SymplecticStiefel` no longer accepts `hamiltonian_norm` as an alias for `σ`.
* `mean!` and `median!` no longer accept `extrinsic_method` (should be replaced with `e = ExtrinsicEstimation(extrinsic_method)`).
* As a result of making `Distributions.jl` and `RecursiveArrayTools.jl` weak dependencies the following symbols are no longer exported from `Manifolds.jl`. Essential functionality is still available but distribution-related features may change in the future without a breaking release.
Expand Down
6 changes: 3 additions & 3 deletions src/manifolds/FiberBundle.jl
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,12 @@ Vector transport type on [`FiberBundle`](@ref).
# Fields
* `method_horizonal` – vector transport method of the horizontal part (related to manifold M)
* `method_horizontal` – vector transport method of the horizontal part (related to manifold M)
* `method_vertical` – vector transport method of the vertical part (related to fibers).
The vector transport is derived as a product manifold-style vector transport.
The considered product manifold is the product between the manifold ``\mathcal M``
and the topological vector space isometric to the fiber.
and the space corresponding to the fiber.
# Constructor
Expand All @@ -37,7 +37,7 @@ struct FiberBundleProductVectorTransport{
end
function FiberBundleProductVectorTransport(
M::AbstractManifold=ManifoldsBase.DefaultManifold(),
fiber::FiberType=ManifoldsBase.TangentSpaceType();
fiber::FiberType=TangentSpaceType();
vector_transport_method_horizontal::AbstractVectorTransportMethod=default_vector_transport_method(
M,
),
Expand Down
7 changes: 0 additions & 7 deletions src/manifolds/VectorBundle.jl
Original file line number Diff line number Diff line change
@@ -1,11 +1,4 @@

"""
const VectorBundleVectorTransport = FiberBundleProductVectorTransport
Deprecated: an alias for `FiberBundleProductVectorTransport`.
"""
const VectorBundleVectorTransport = FiberBundleProductVectorTransport

"""
fiber_bundle_transport(M::AbstractManifold, fiber::FiberType)
Expand Down
6 changes: 0 additions & 6 deletions src/statistics.jl
Original file line number Diff line number Diff line change
@@ -1,9 +1,3 @@
"""
AbstractEstimationMethod
Deprecated alias for `AbstractApproximationMethod`
"""
const AbstractEstimationMethod = AbstractApproximationMethod

_unit_weights(n::Int) = StatsBase.UnitWeights{Float64}(n)

Expand Down

0 comments on commit b2df4a0

Please sign in to comment.