Error message for identity_element on ProductManifold without RAT.jl

JuliaManifolds · Aug 29, 2024 · cc691d7 · cc691d7
1 parent c8258b9
commit cc691d7
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 3 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.10.1] – 2024-08-29
+
+### Changed
+
+* `identity_element` on `ProductManifold` without `RecursiveArrayTools.jl` now prints a useful error message.
+
 ## [0.10.0] – 2024-08-24
 
 ### Changed

diff --git a/Project.toml b/Project.toml
@@ -1,7 +1,7 @@
 name = "Manifolds"
 uuid = "1cead3c2-87b3-11e9-0ccd-23c62b72b94e"
 authors = ["Seth Axen <seth.axen@gmail.com>", "Mateusz Baran <mateuszbaran89@gmail.com>", "Ronny Bergmann <manopt@ronnybergmann.net>", "Antoine Levitt <antoine.levitt@gmail.com>"]
-version = "0.10.0"
+version = "0.10.1"
 
 [deps]
 Einsum = "b7d42ee7-0b51-5a75-98ca-779d3107e4c0"
@@ -55,7 +55,7 @@ HybridArrays = "0.4"
 Kronecker = "0.4, 0.5"
 LinearAlgebra = "1.6"
 ManifoldDiff = "0.3.7"
-ManifoldsBase = "0.15.8"
+ManifoldsBase = "0.15.15"
 Markdown = "1.6"
 MatrixEquations = "2.2"
 NLsolve = "4"

diff --git a/src/groups/group.jl b/src/groups/group.jl
@@ -273,7 +273,8 @@ end
 
 function allocate_result(G::AbstractDecoratorManifold, f::typeof(identity_element))
     apf = allocation_promotion_function(G, f, ())
-    return zeros(apf(Float64), representation_size(G)...)
+    rs = representation_size(G)
+    return ManifoldsBase.allocate_result_array(G, f, apf(Float64), rs)
 end
 
 @doc raw"""