-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rand for GL and Heisenberg group #610
Conversation
Codecov Report
@@ Coverage Diff @@
## master #610 +/- ##
==========================================
+ Coverage 98.92% 99.01% +0.09%
==========================================
Files 102 102
Lines 10007 10034 +27
==========================================
+ Hits 9899 9935 +36
+ Misses 108 99 -9
... and 9 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My only remark for this PR is (the typical Ronny-one), that both new rand methods should be documented.
I was actually somewhat expecting another long discussion whether this is the right distribution 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides the one typo, this looks good to me.
Co-authored-by: Ronny Bergmann <git@ronnybergmann.net>
…/Manifolds.jl into mbaran/rand-group
… error leading to incomplete coverage)
Useful for testing here: #609 .