Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Julia 1.10-beta to CI, remove nightly #648

Merged
merged 3 commits into from
Nov 4, 2023

Conversation

mateuszbaran
Copy link
Member

I think currently Julia nightly tests are more confusing than helpful and we should limit testing to alpha/beta builds of Julia.

@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #648 (bd27542) into master (ab49d04) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #648   +/-   ##
=======================================
  Coverage   99.40%   99.41%           
=======================================
  Files         108      108           
  Lines       10600    10600           
=======================================
+ Hits        10537    10538    +1     
+ Misses         63       62    -1     

see 1 file with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@mateuszbaran
Copy link
Member Author

Regarding failure, see JuliaLinearAlgebra/LinearMaps.jl#214

@kellertuer
Copy link
Member

I agree on the nightly issue, they were broken for some time now and not helpful; so let's not run them; we could still keep beta versions in a nightly-like fashion to not break tests?

@mateuszbaran
Copy link
Member Author

I'm not sure about running alpha/beta builds in a "nightly" CI. Once we merge the PR enabling support for it, ideally things should not break. If things don't work, we would just delay merging that PR and regressions should be very rare.

@kellertuer
Copy link
Member

Ok, that is also fine with me, since you might be right, the beta versions should be more stable than Nightly.

@mateuszbaran mateuszbaran reopened this Oct 9, 2023
@mateuszbaran
Copy link
Member Author

LinearMaps strikes again: JuliaLinearAlgebra/LinearMaps.jl#219 .

@mateuszbaran mateuszbaran merged commit f9a6b19 into master Nov 4, 2023
25 checks passed
@kellertuer kellertuer deleted the mbaran/update-ci-julia-1.10 branch May 4, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants