-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hyperbolic Riemann tensor #651
Conversation
Codecov Report
@@ Coverage Diff @@
## master #651 +/- ##
==========================================
- Coverage 99.22% 99.20% -0.02%
==========================================
Files 106 106
Lines 10430 10433 +3
==========================================
+ Hits 10349 10350 +1
- Misses 81 83 +2
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Thanks, I think this is a good addition.
What is computing sectional curvatures useful for? I'm generally trying to avoid adding functions that don't have a practical use. Note that most of MetricManifold stuff needs to be revisited so don't pay too much attention to it. |
Co-authored-by: Mateusz Baran <mateuszbaran89@gmail.com>
Honestly, I only thought about it because I am using it in what I am doing at the moment, which is also the reason why I implemented the Riemann tensor for the hyperbolic space. I thought about it as just a utility function, much like some cost functions are exported by Manopt. However, I am not sure about all the possible use cases, and one might of course argue that it only takes a few lines to implement if needed. |
OK, sure, if you find it useful then we can add it to Manifolds.jl 🙂 |
I think that is a useful function that could be added (in a new PR), but should then also be properly documented what the interface is and what it does. edit: Oh I misread the title, this function is indeed nice and useful here :) Thanks for documenting it carefully and directly also adding tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me (lgtm).
I still don't understand why codecov/project fails. It laments an indirect change in the circle group, but when you look at it, it has no relation whatsoever to my changes. |
Nighlty is ok to fail and the rest looks good. all is fine. |
This small PR implements the Riemann tensor for the
Hyperbolic
manifold, analogous to the one on theSphere
.I know I should probably open an issue about this, but since it's related: I was wondering whether it would make sense to implement a
sectional_curvature
method for the manifolds where ariemann_tensor
is available.I also added a new textbook reference for the formula and myself to the list of contributors.