Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more SE2 and SE3 performance dispatches #660

Merged
merged 6 commits into from
Oct 17, 2023

Conversation

Affie
Copy link
Contributor

@Affie Affie commented Oct 12, 2023

  • Added get_coordinates and get_vector specialized dispatches: vee and hat do not always seem to dispatch without allocations and there are places where we use get_vector/coordinates.
  • Not only SVector for coordinates: we take the coordinates from a larger vector in some places.

@Affie
Copy link
Contributor Author

Affie commented Oct 12, 2023

@mateuszbaran would you mind helping to implement the performance dispatches I tried to do in this PR? I thought I could help, but I'm still figuring out Manifolds.jl

@mateuszbaran
Copy link
Member

Sure, I will check it out.

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #660 (9ca5550) into master (106a8f3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #660   +/-   ##
=======================================
  Coverage   99.22%   99.22%           
=======================================
  Files         106      106           
  Lines       10481    10488    +7     
=======================================
+ Hits        10400    10407    +7     
  Misses         81       81           
Files Coverage Δ
src/groups/special_euclidean.jl 99.63% <100.00%> (+<0.01%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Affie
Copy link
Contributor Author

Affie commented Oct 16, 2023

Not only SVector for coordinates: we take the coordinates from a larger vector in some places.

It looks like the view causes allocations in some instances, so perhaps your original SA is better. Will it be a problem with the coordinates c::AbstractVector and not s::SArray. What I tested so far looks like it doesn't have allocations.

@mateuszbaran
Copy link
Member

It looks like the view causes allocations in some instances, so perhaps your original SA is better. Will it be a problem with the coordinates c::AbstractVector and not s::SArray. What I tested so far looks like it doesn't have allocations.

SA should not be a problem.

@mateuszbaran mateuszbaran merged commit b03cabc into JuliaManifolds:master Oct 17, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants