-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more SE2 and SE3 performance dispatches #660
Add more SE2 and SE3 performance dispatches #660
Conversation
Affie
commented
Oct 12, 2023
- Added get_coordinates and get_vector specialized dispatches: vee and hat do not always seem to dispatch without allocations and there are places where we use get_vector/coordinates.
- Not only SVector for coordinates: we take the coordinates from a larger vector in some places.
@mateuszbaran would you mind helping to implement the performance dispatches I tried to do in this PR? I thought I could help, but I'm still figuring out Manifolds.jl |
Sure, I will check it out. |
Codecov Report
@@ Coverage Diff @@
## master #660 +/- ##
=======================================
Coverage 99.22% 99.22%
=======================================
Files 106 106
Lines 10481 10488 +7
=======================================
+ Hits 10400 10407 +7
Misses 81 81
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
It looks like the view causes allocations in some instances, so perhaps your original SA is better. Will it be a problem with the coordinates |
|