Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #665 #666

Merged
merged 3 commits into from
Oct 26, 2023
Merged

Fix #665 #666

merged 3 commits into from
Oct 26, 2023

Conversation

mateuszbaran
Copy link
Member

Fixes #665 , and one other minor bug with is_vector.

@mateuszbaran mateuszbaran added Ready-for-Review A label for pull requests that are feature-ready preview docs Add this label if you want to see a PR-preview of the documentation labels Oct 25, 2023
Copy link
Member

@kellertuer kellertuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, in general this is not possible to do – I wonder why that did work before then, though. Did we “materialize” (allocate) the identity as an element on the manifold?

@kellertuer
Copy link
Member

Ah, I saw in other Changelogs, that they would link to errors/issues that are resolved by changes, do we want to do the same? Might be nice in the rendered docs.

@mateuszbaran
Copy link
Member Author

I'm not sure, I haven't checked what we did before.

Sure, I can add a link to the issue that was fixed.

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #666 (c0b3b7f) into master (b0ab892) will increase coverage by 0.00%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #666   +/-   ##
=======================================
  Coverage   99.40%   99.40%           
=======================================
  Files         108      108           
  Lines       10593    10597    +4     
=======================================
+ Hits        10530    10534    +4     
  Misses         63       63           
Files Coverage Δ
src/groups/GroupManifold.jl 100.00% <100.00%> (ø)
src/groups/general_unitary_groups.jl 100.00% <100.00%> (ø)
src/groups/translation_group.jl 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mateuszbaran mateuszbaran merged commit 4fce452 into master Oct 26, 2023
19 checks passed
@kellertuer kellertuer deleted the mbaran/rand-at-identity branch May 4, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview docs Add this label if you want to see a PR-preview of the documentation Ready-for-Review A label for pull requests that are feature-ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minor bug with rand at Identity
2 participants