Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message for identity_element on ProductManifold without RAT.jl #739

Merged
merged 5 commits into from
Aug 30, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [0.10.1] – 2024-08-29

### Changed

* `identity_element` on `ProductManifold` without `RecursiveArrayTools.jl` now prints a useful error message.

## [0.10.0] – 2024-08-24

### Changed
Expand Down
4 changes: 2 additions & 2 deletions Project.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "Manifolds"
uuid = "1cead3c2-87b3-11e9-0ccd-23c62b72b94e"
authors = ["Seth Axen <seth.axen@gmail.com>", "Mateusz Baran <mateuszbaran89@gmail.com>", "Ronny Bergmann <manopt@ronnybergmann.net>", "Antoine Levitt <antoine.levitt@gmail.com>"]
version = "0.10.0"
version = "0.10.1"

[deps]
Einsum = "b7d42ee7-0b51-5a75-98ca-779d3107e4c0"
Expand Down Expand Up @@ -55,7 +55,7 @@ HybridArrays = "0.4"
Kronecker = "0.4, 0.5"
LinearAlgebra = "1.6"
ManifoldDiff = "0.3.7"
ManifoldsBase = "0.15.8"
ManifoldsBase = "0.15.15"
Markdown = "1.6"
MatrixEquations = "2.2"
NLsolve = "4"
Expand Down
3 changes: 2 additions & 1 deletion src/groups/group.jl
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,8 @@

function allocate_result(G::AbstractDecoratorManifold, f::typeof(identity_element))
apf = allocation_promotion_function(G, f, ())
return zeros(apf(Float64), representation_size(G)...)
rs = representation_size(G)
return ManifoldsBase.allocate_result_array(G, f, apf(Float64), rs)

Check warning on line 277 in src/groups/group.jl

View check run for this annotation

Codecov / codecov/patch

src/groups/group.jl#L276-L277

Added lines #L276 - L277 were not covered by tests
end

@doc raw"""
Expand Down
Loading