-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce has_components
for Euclidean
#759
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #759 +/- ##
=======================================
Coverage 96.38% 96.39%
=======================================
Files 123 123
Lines 11438 11441 +3
=======================================
+ Hits 11025 11028 +3
Misses 413 413 ☔ View full report in Codecov by Sentry. |
Currently To be precise, we currently have that
yields |
Nice. Could you also add tests that
Right, yes, |
sure I can add those lines. For the transparency, we should probably do that in |
Yes, transparency should be in ManifoldsBase.jl. |
Sure, will do. |
Added the test for distance and norm. Also started the |
Sure, that's fine. |
BTW, I haven't tagged 0.10.4 yet so this could be a part of it together with Oliver's PR. |
Just saw that 0.10.4 is not yet registered, then this can also be part of that. But I will do the transparency first in ManifoldsBase maybe. |
# Conflicts: # NEWS.md
Already merged master here, but since we just merged a branch in 3 packages, all CIs might take a time ;) afterward I will merge this as well. We could register those two as 0.10.4 for sure. |
Since we now have available that
for the -norm, this introduces it also for Euclidean. I do not directly see other manifolds that would be available for that.