Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lie bracket is zero on so(2) #761

Merged

Conversation

olivierverdier
Copy link
Contributor

After some computations, there are numerical errors in the elements of $\mathfrak{so}(2)$. This PR ensures that even after errors, the Lie bracket is exactly zero.

Copy link
Member

@mateuszbaran mateuszbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good idea, I've just made it slightly faster.

src/groups/general_unitary_groups.jl Outdated Show resolved Hide resolved
src/groups/general_unitary_groups.jl Outdated Show resolved Hide resolved
Co-authored-by: Mateusz Baran <mateuszbaran89@gmail.com>
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.39%. Comparing base (b3c0fa4) to head (32fbffa).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #761   +/-   ##
=======================================
  Coverage   96.39%   96.39%           
=======================================
  Files         123      123           
  Lines       11441    11445    +4     
=======================================
+ Hits        11028    11032    +4     
  Misses        413      413           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mateuszbaran mateuszbaran merged commit 54c774e into JuliaManifolds:master Oct 21, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants