-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adaptive Regularisation with Cubics (ARC) Solver #277
Conversation
# Conflicts: # src/Manopt.jl # src/plans/stopping_criterion.jl # src/solvers/gradient_descent.jl
…e one parameter is still unclear to me.
🥳finally found my last few bugs such that now also GradientDescent and CG can be used as sub solvers – now it just remains to
|
The only thing to maybe consider is, that for the gradient based sub solvers of ARC, there is |
Currently code coverage fails because we have one spurious line missed on code not changed here. All lines coded here are covered by tests. |
# Conflicts: # src/Manopt.jl # src/plans/subsolver_plan.jl # test/plans/test_debug.jl
… from 0.4.31. Remove ARC example since that is more extended in the ManoptExamples.
Let's leave the optimised step size for a later PR. |
This PR is a slight rework from the work @mathiasrm1 did in his master thesis this semester. Until now
adaptive_regularization_with_cubics(M, mho, ...; kwargs...)
status_summary
for the new state.maybe implement the exact best step size for the gradient descent subsolver