Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a typo in trust regions and extend Frank-Wolfe docs #284

Merged
merged 4 commits into from
Aug 3, 2023

Conversation

kellertuer
Copy link
Member

This fixes the typo reported in #283.

It also extends the docs of Frank Wolfe to report on all available keywords and especially the default sub solver.

@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #284 (19dedd6) into master (16fd6c0) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #284      +/-   ##
==========================================
+ Coverage   99.70%   99.73%   +0.03%     
==========================================
  Files          73       73              
  Lines        6524     6522       -2     
==========================================
  Hits         6505     6505              
+ Misses         19       17       -2     
Files Changed Coverage Δ
src/solvers/FrankWolfe.jl 100.00% <ø> (ø)
src/solvers/trust_regions.jl 98.49% <100.00%> (+1.45%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kellertuer kellertuer merged commit 583efd2 into master Aug 3, 2023
13 checks passed
@kellertuer kellertuer deleted the kellertuer/fix-283 branch December 16, 2023 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant