Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v2.0.0 #12

Merged
merged 2 commits into from
Oct 4, 2024
Merged

Release v2.0.0 #12

merged 2 commits into from
Oct 4, 2024

Conversation

jlapeyre
Copy link
Collaborator

@jlapeyre jlapeyre commented Oct 4, 2024

Version 1.0.0 had largely the same behavior that development versions did. In particular, ilog2(x) threw a DomainError for most integer types with x less than or equal to zero. But other types, such as Float64 did not cause a DomainError to be thrown, and instead returned ilog2(abs(x)).

Version 2.0.0 extends the behavior for integers to all types. Now there is a single entry point to ilog2 that makes this check.

Version 1.0.0 had largely the same behavior that development versions did.  In particular,
`ilog2(x)` threw a `DomainError` for most integer types with `x` less than or equal to
zero. But other types, such as `Float64` did not cause a `DomainError` to be thrown, and instead
returned `ilog2(abs(x))`.

Version `2.0.0` extends the behavior for integers to all types. Now there is a single entry point
to `ilog2` that makes this check.
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (37ea876) to head (559d682).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #12   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           20        22    +2     
=========================================
+ Hits            20        22    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

One test is slightly different for Julia 1.5 and earlier
@jlapeyre jlapeyre merged commit f115a4f into master Oct 4, 2024
8 checks passed
@jlapeyre jlapeyre deleted the release-2.0 branch October 4, 2024 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant