some renames #134
Closed
some renames #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unused and untested.
Not used currently.
pullback has a huge potential for naming conflickts, and pullbck is more in line with pushfwd. Also simplify implementation of pullbck.
Bind has too much naming conflict potential with Base.bind. The rightarrowtail operator looks very similar to the `>=>` "fish" operator (e.g. in Haskell), which is not a monadic bind.
Removes the integral operators from MeasureBase, to be re-introduced in the submodule MeasureOperators. Also improves the likelihood documentation.
A rebase can easily be written explicitly.
To be re-introduced in sub-module MeasureOperators.
`mintegral` should be used instead to express posteriors.
To be reintroduced in submodule MeasureOperators
Absolute continuity is not really implemented yet.
Having the operators in a sub-module makes it easier for users to control whether of they want them in their namespace. Operators have a larger naming conflict potential.
Co-authored-by: Chad Scherrer <chad.scherrer@gmail.com>
Co-authored-by: Chad Scherrer <chad.scherrer@gmail.com>
Will be used a lot when bridging from Distributions to MeasureBase.
|
oschulz
force-pushed
the
hierarchical-dev
branch
from
80913b1
to
2d017c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #120, there's currently a lot of cases where some
foofunction dispatches to_generic_foo_impl. This seems very wordy, which IMO makes the code a little cluttery and hard to read. This PR replaces things of the form_generic_foo_implwith_foo.The one case it doesn't yet handle is
_generic_mcombine_impl_*, because the naming scheme for dispatch there seems very different.