Skip to content

Remove methods such as sinτ #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hyrodium wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Remove methods such as sinτ #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a4d87a
remove sinτ, cosτ, sincosτ, cisτ, and modτ
hyrodium Feb 28, 2023
bf826d4
remove tests for sinτ, cosτ, sincosτ, cisτ, and modτ
hyrodium Feb 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 12 additions & 19 deletions src/Tau.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,20 +3,18 @@ module Tau
import IrrationalConstants

export tau, τ,
sintau, costau, sincostau, cistau, modtau,
sinτ, cosτ, sincosτ, cisτ, modτ
sintau, costau, sincostau, cistau, modtau

# Definition of τ as irrational constant
const τ = IrrationalConstants.twoπ
const tau = τ

const modτ = mod2pi
const modtau = modτ
const modtau = mod2pi

# Trigonometric functions
sinτ(x) = sinpi(2 * x)
cosτ(x) = cospi(2 * x)
function sincosτ(x)
sintau(x) = sinpi(2 * x)
costau(x) = cospi(2 * x)
function sincostau(x)
y = 2 * x
# sincospi was added in https://github.com/JuliaLang/julia/pull/35816
@static if VERSION < v"1.6.0-DEV.292"
Expand All @@ -25,29 +23,24 @@ function sincosτ(x)
return sincospi(y)
end
end
cisτ(x::Real) = complex(reverse(sincosτ(x))...)
function cisτ(z::Complex)
sitau, cotau = sincosτ(z)
cistau(x::Real) = complex(reverse(sincostau(x))...)
function cistau(z::Complex)
sitau, cotau = sincostau(z)
re_sitau, im_sitau = reim(sitau)
re_cotau, im_cotau = reim(cotau)
return complex(re_cotau - im_sitau, im_cotau + re_sitau)
end

# Optimization for integers
sinτ(x::Integer) = zero(float(x))
cosτ(x::Integer) = one(float(x))
function sincosτ(x::Integer)
sintau(x::Integer) = zero(float(x))
costau(x::Integer) = one(float(x))
function sincostau(x::Integer)
y = float(x)
return (zero(y), one(y))
end
function cisτ(x::Integer)
function cistau(x::Integer)
y = float(x)
return complex(one(y), zero(y))
end

const sintau = sinτ
const costau = cosτ
const sincostau = sincosτ
const cistau = cisτ

end
7 changes: 0 additions & 7 deletions test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,12 +110,6 @@ end
end
end

@testset "aliases" begin
@test sinτ === sintau
@test cosτ === costau
@test sincosτ === sincostau
@test cisτ === cistau
end
end

# Adapted from julia/test/mod2pi.jl
Expand All @@ -131,5 +125,4 @@ end

# aliases
@test modtau === mod2pi
@test modτ === modtau
end