Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libgeotiff] build against latest PROJ #9586

Merged
merged 3 commits into from
Oct 10, 2024
Merged

Conversation

visr
Copy link
Contributor

@visr visr commented Oct 9, 2024

No description provided.

visr added a commit to visr/Yggdrasil that referenced this pull request Oct 9, 2024
Needs JuliaPackaging#9586.

The recent LERC_jll v4 release broke GDAL_jll since it was an implicit dependency. See JuliaGeo/GDAL.jl#179.

This tries to make a new release compatible with LERC_jll v4, and the latest breaking PROJ release. Since PROJ is also a dependency of libgeotiff this needs JuliaPackaging#9586 first.

It also adds compats for dependencies that did not yet have them.
@eschnett
Copy link
Contributor

eschnett commented Oct 9, 2024

libgeotiff looks for a jpeg library, and builds against it if it finds it. It might be good to be explicit about this, i.e. to either disable jpeg support, or to enable it and add JpegTurbo_jll as dependency.

Also, this recipe builds against Libtiff_jll version 4.5.1. That version is built against LERC_jll version 3. If you want to use LERC_jll version 4 then you need to use at least Libtiff_jll version 4.7.0. There's nothing wrong with the current setup; just be aware that you're implicitly using LERC_jll 3.

@eschnett
Copy link
Contributor

eschnett commented Oct 9, 2024

To be able to build aarch64-*-freebsd (that's a new architecture) you will need to use at least Libtiff_jll 4.7. Earlier versions of Libtiff_jll haven't been built for aarch64-*-freebsd. It's likely that a few other package also don't exist yet for aarch64-*-freebsd, so it might be best to disable that architecture with a respective comment.

@visr
Copy link
Contributor Author

visr commented Oct 10, 2024

libgeotiff looks for a jpeg library

Thanks, I made it an explicit dependency. Similarly for zlib.

To be able to build aarch64-*-freebsd

I already set libtiff compat to 4.7, the problem is probably libcurl. So like recommended in #9588 (comment) I disabled aarch64-*-freebsd support for now.

@ViralBShah
Copy link
Member

Is this good to merge?

@visr
Copy link
Contributor Author

visr commented Oct 10, 2024

Yes.

@ViralBShah ViralBShah merged commit 9989299 into JuliaPackaging:master Oct 10, 2024
19 checks passed
@visr visr deleted the gggdal branch October 10, 2024 13:24
visr added a commit to visr/Yggdrasil that referenced this pull request Oct 10, 2024
In JuliaPackaging#9586 I set compat to 1.3. But the latest version I can load on Julia 1.10 is `v1.2.13+1`. This is why JuliaRegistries/General#116992 got stuck.
ViralBShah pushed a commit that referenced this pull request Oct 10, 2024
In #9586 I set compat to 1.3. But the latest version I can load on Julia 1.10 is `v1.2.13+1`. This is why JuliaRegistries/General#116992 got stuck.
ViralBShah pushed a commit that referenced this pull request Oct 10, 2024
* [GDAL] Add explicit LERC dependency

Needs #9586.

The recent LERC_jll v4 release broke GDAL_jll since it was an implicit dependency. See JuliaGeo/GDAL.jl#179.

This tries to make a new release compatible with LERC_jll v4, and the latest breaking PROJ release. Since PROJ is also a dependency of libgeotiff this needs #9586 first.

It also adds compats for dependencies that did not yet have them.

* Rebuild now that libgeotiff_jll is updated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants