Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix border ticks of framestyle :box #4832

Merged
merged 2 commits into from
Oct 13, 2023
Merged

Fix border ticks of framestyle :box #4832

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d1727e
Fix border tick of framestyle :box
lch Oct 10, 2023
13d4b71
Format with JuliaFormatter
lch Oct 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions src/axes.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -886,6 +886,21 @@ function axis_drawing_info(sp, letter)
grid_factor_2d[] / ax_length,
ax[:tick_direction] !== :none,
)
if sp[:framestyle] === :box
add_major_or_minor_segments_2d(
sp,
ax,
oax,
reverse(oas),
oamM,
first(ticks),
ax[:grid],
tick_segments,
grid_segments,
grid_factor_2d[] / ax_length,
ax[:tick_direction] !== :none,
)
end

# add minor grid segments
if ax[:minorticks] ∉ (:none, nothing, false) || ax[:minorgrid]
Expand All @@ -902,6 +917,21 @@ function axis_drawing_info(sp, letter)
grid_factor_2d[] / 2ax_length,
true,
)
if sp[:framestyle] === :box
add_major_or_minor_segments_2d(
sp,
ax,
oax,
reverse(oas),
oamM,
minor_ticks,
ax[:minorgrid],
tick_segments,
minorgrid_segments,
grid_factor_2d[] / 2ax_length,
true,
)
end
end
end
end
Expand Down
Loading