Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses a linting issue by adding explicit imports for the / and ⋅ operators from the LinearAlgebra module. The repository uses ExplicitImports.jl to enforce explicit import declarations, which flagged these operators as needing to be explicitly imported.
Key changes:
- Added
/and⋅to the explicit imports from LinearAlgebra module
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| using Krylov: Krylov, cg!, cg_lanczos_shift! | ||
| using Krylov: CgLanczosShiftWorkspace, CgWorkspace, CglsWorkspace, LsqrWorkspace, krylov_solve! | ||
| using LinearAlgebra: LinearAlgebra, Symmetric, mul!, norm | ||
| using LinearAlgebra: LinearAlgebra, Symmetric, mul!, norm, /, ⋅ |
There was a problem hiding this comment.
The division operator / should not be imported from LinearAlgebra as it is a base Julia operator available globally. The dot product operator ⋅ is appropriate to import from LinearAlgebra, but / should be removed from this import list. If the linter is flagging /, it may be a false positive or misconfiguration since / is not part of LinearAlgebra's exports.
| using LinearAlgebra: LinearAlgebra, Symmetric, mul!, norm, /, ⋅ | |
| using LinearAlgebra: LinearAlgebra, Symmetric, mul!, norm, ⋅ |
Related issues
Closes #
Checklist