Skip to content

Fix Linter import#163

Merged
tmigot merged 1 commit intomainfrom
fix-linter
Dec 16, 2025
Merged

Fix Linter import#163
tmigot merged 1 commit intomainfrom
fix-linter

Conversation

@tmigot
Copy link
Member

@tmigot tmigot commented Dec 16, 2025

Related issues

Closes #

Checklist

  • I am following the contributing guidelines
  • Tests are passing
  • Lint workflow is passing
  • Docs were updated and workflow is passing

Copilot AI review requested due to automatic review settings December 16, 2025 13:08
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses a linting issue by adding explicit imports for the / and operators from the LinearAlgebra module. The repository uses ExplicitImports.jl to enforce explicit import declarations, which flagged these operators as needing to be explicitly imported.

Key changes:

  • Added / and to the explicit imports from LinearAlgebra module

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

using Krylov: Krylov, cg!, cg_lanczos_shift!
using Krylov: CgLanczosShiftWorkspace, CgWorkspace, CglsWorkspace, LsqrWorkspace, krylov_solve!
using LinearAlgebra: LinearAlgebra, Symmetric, mul!, norm
using LinearAlgebra: LinearAlgebra, Symmetric, mul!, norm, /, ⋅
Copy link

Copilot AI Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The division operator / should not be imported from LinearAlgebra as it is a base Julia operator available globally. The dot product operator is appropriate to import from LinearAlgebra, but / should be removed from this import list. If the linter is flagging /, it may be a false positive or misconfiguration since / is not part of LinearAlgebra's exports.

Suggested change
using LinearAlgebra: LinearAlgebra, Symmetric, mul!, norm, /,
using LinearAlgebra: LinearAlgebra, Symmetric, mul!, norm,

Copilot uses AI. Check for mistakes.
@tmigot tmigot merged commit 9352d4d into main Dec 16, 2025
12 of 13 checks passed
@tmigot tmigot deleted the fix-linter branch December 16, 2025 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants