R2: remove nu keyword argument and replace with sigma #232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #232 +/- ##
===========================================
+ Coverage 61.53% 86.14% +24.60%
===========================================
Files 11 13 +2
Lines 1292 1573 +281
===========================================
+ Hits 795 1355 +560
+ Misses 497 218 -279 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
MaxenceGollier
commented
Sep 29, 2025
Comment on lines
-321
to
-332
| if isa(solver.subsolver, R2Solver) #FIXME | ||
| solve!(solver.subsolver, solver.subpb, solver.substats, x = s, atol = sub_atol, ν = ν) | ||
| else | ||
| solve!( | ||
| solver.subsolver, | ||
| solver.subpb, | ||
| solver.substats, | ||
| x = s, | ||
| atol = sub_atol, | ||
| σk = σk, #FIXME | ||
| ) | ||
| end |
Collaborator
Author
There was a problem hiding this comment.
I am not sure to understand why we used ν when we called LM with R2Solver and σk else.
Collaborator
There was a problem hiding this comment.
I think there is no sigma keyword in R2.solve! but
Otherwise, we would call solve!(sigma = nu) in R2, as is done in R2DH.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#231
Added a test in R2N and R2DH to make sure that
sigmak >= sigma_min.