Consistently skip self edges when constructing Metis.Graph.

JuliaSparse · Jan 19, 2023 · 905ab8b · 905ab8b
1 parent 560a056
commit 905ab8b
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/ext/GraphsCommon.jl b/ext/GraphsCommon.jl
@@ -15,6 +15,7 @@ function graph(G)
     for j in 1:N
         ne = 0
         for i in outneighbors(G, j)
+            i == j && continue # skip self edges
             ne += 1
             adjncy_i += 1
             adjncy[adjncy_i] = i

diff --git a/src/Metis.jl b/src/Metis.jl
@@ -56,13 +56,12 @@ function graph(G::SparseMatrixCSC; weights::Bool=false, check_hermitian::Bool=tr
         n_rows = 0
         for k in G.colptr[j] : (G.colptr[j+1] - 1)
             i = G.rowval[k]
-            if i != j # don't include diagonal elements
-                n_rows += 1
-                adjncy_i += 1
-                adjncy[adjncy_i] = i
-                if weights
-                    adjwgt[adjncy_i] = G.nzval[k]
-                end
+            i == j && continue # skip self edges
+            n_rows += 1
+            adjncy_i += 1
+            adjncy[adjncy_i] = i
+            if weights
+                adjwgt[adjncy_i] = G.nzval[k]
             end
         end
         xadj[j+1] = xadj[j] + n_rows