Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added example on how to use BSON-file #98

Merged
merged 3 commits into from
Oct 28, 2021

Conversation

mauro3
Copy link
Contributor

@mauro3 mauro3 commented Oct 27, 2021

Fixes #97

@@ -32,7 +32,7 @@ to the value of interest.

```julia
using ReferenceTests
@test_reference "stringtest1.txt" string(collect(1:20))
@test_reference "stringtest1.txt" collect(1:20)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm actually a bit confused how and when things are compared as strings and when things are converted. Anyway, the string is not needed here.

@johnnychen94
Copy link
Member

The test failure is very likely due to an upstream ImageMagick bug, adding ImageIO as a test dependency should work it around.

Copy link
Member

@johnnychen94 johnnychen94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mauro3
Copy link
Contributor Author

mauro3 commented Oct 28, 2021

Cool. I'll add ImageIO to the test-deps. I will also add a BSON-test case.

@johnnychen94
Copy link
Member

Okay, I'll close #100 then so that we don't get conflict.

Copy link
Member

@johnnychen94 johnnychen94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nightly failure should be unrelated.

Project.toml Outdated Show resolved Hide resolved
@johnnychen94 johnnychen94 merged commit 73f6e23 into JuliaTesting:master Oct 28, 2021
@mauro3
Copy link
Contributor Author

mauro3 commented Oct 28, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to compare Arrays of Numbers, e.g. Floats
2 participants