Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

done #509

Merged
merged 1 commit into from
Jan 2, 2025
Merged

done #509

merged 1 commit into from
Jan 2, 2025

Conversation

pat-alt
Copy link
Member

@pat-alt pat-alt commented Jan 2, 2025

No description provided.

@pat-alt pat-alt linked an issue Jan 2, 2025 that may be closed by this pull request
Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.37%. Comparing base (218b297) to head (8c01dc3).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #509   +/-   ##
=======================================
  Coverage   91.37%   91.37%           
=======================================
  Files          91       91           
  Lines        2005     2005           
=======================================
  Hits         1832     1832           
  Misses        173      173           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pat-alt pat-alt merged commit 1ba0ee1 into main Jan 2, 2025
9 checks passed
@pat-alt pat-alt deleted the validity-argmax branch January 2, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validity should simply be defined in terms of argmax
1 participant