Calculate time span for AzureConsumptionPeriod when using -DoAzureConsumptionPreviousMonth
#250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 21, 2024 12:13
This commits ensures the correct amount of days data is collected over is written in the generated reports. Before this commit, when using the DoAzureConsumptionPreviousMonth the AzureConsumptionPeriod param was no longer technically relevant, but was used in reports, e.g. it would read as the last X amount of days was collected based on the param value provided, while the actual amount of days depends on the length of the previous month. (between 28 - 31 days). With this commit the correct amount of days is used throughout the reports, which lead to some other phrasing changes (e.g. it is not necessarily the 'last' X days the report is collected over).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commits ensures the correct amount of days data is collected over is written in the generated reports. Before this commit, when using the DoAzureConsumptionPreviousMonth the AzureConsumptionPeriod param was no longer technically relevant, but was used in reports, e.g. it would read as the last X amount of days was collected based on the param value provided, while the actual amount of days depends on the length of the previous month. (between 28 - 31 days).
With this commit the correct amount of days is used throughout the reports, which lead to some other phrasing changes (e.g. it is not necessarily the 'last' X days the report is collected over).
Run identifier: A0BB373FB13C57D8EFFF319E87814FD7C2BBCB46F5D1FF016383F3CF00DB85DF56D77A4E1E58FE095FDFD71C01A571C0A5EFB6429C241E9AA17BBE875DDFCAB2