Skip to content

Commit

Permalink
Merge pull request #1053 from rahkumar651991/doc_edit
Browse files Browse the repository at this point in the history
Modify the docstring for proper return value for sw.install
  • Loading branch information
Nitin Kr authored Jul 7, 2020
2 parents a574903 + c9b1c61 commit 220cd09
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 6 deletions.
2 changes: 1 addition & 1 deletion lib/jnpr/junos/factory/optable.py
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ def generate_sax_parser_input(obj):
"""
Used to generate xml object from Table/view to be used in SAX parsing
Args:
obj: self object which contains table/view details
obj: self object which contains table/view details
Returns: lxml etree object to be used as sax parser input
Expand Down
3 changes: 2 additions & 1 deletion lib/jnpr/junos/utils/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -177,8 +177,9 @@ def commit_check(self, **kvargs):
Perform a commit check. If the commit check passes, this function
will return ``True``. If the commit-check results in warnings, they
are reported and available in the Exception errs.
:param int timeout: If provided the command will wait for completion
using the provided value as timeout (seconds).
using the provided value as timeout (seconds).
:returns: ``True`` if commit-check is successful (no errors)
:raises CommitError: When errors detected in candidate configuration.
Expand Down
8 changes: 4 additions & 4 deletions lib/jnpr/junos/utils/sw.py
Original file line number Diff line number Diff line change
Expand Up @@ -851,9 +851,9 @@ def myprogress(dev, report):
(Optional) Additional keyword arguments are passed through to the
"package add" RPC.
:returns:
* ``True`` when the installation is successful
* ``False`` otherwise
:returns: tuple(<status>, <msg>)
* status : ``True`` when the installation is successful and ``False`` otherwise
* msg : msg received as response or error message created
"""
if issu is True and nssu is True:
raise TypeError("install function can either take issu or nssu not both")
Expand Down Expand Up @@ -1206,7 +1206,7 @@ def halt(self, in_min=0, at=None, all_re=True, other_re=False):
then the action is performed on the other REs in the system.
:returns:
*rpc response message (string) if command successful
* rpc response message (string) if command successful
"""
if self._dev.facts["_is_linux"]:
cmd = E("request-shutdown-halt")
Expand Down

0 comments on commit 220cd09

Please sign in to comment.