Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 'member' to reboot RPC only when it's not None #1290

Merged
merged 2 commits into from
Jan 15, 2024

Conversation

MicLennartz
Copy link
Contributor

The current logic adds the 'member' attribute to the request-reboot RPC, even if the member attribute is 'None' (default) while the target device is running on a single-node virtual chassis.

This causes the RPC call to fail.

-> parentheses were missing to reflect the right logic

parentheses were missing to reflect the right logic
@@ -1131,8 +1131,8 @@ def _system_operation(
elif self._mixed_VC is True:
cmd.append(E("all-members"))
elif (
self._multi_VC_nsync is True
or self._multi_VC is True
(self._multi_VC_nsync is True
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly fix the format for your fix by running "black" tools. Workflow is failing with your fix

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, format is now updated according to 'black'.

@dineshbaburam91 dineshbaburam91 merged commit 422ca38 into Juniper:master Jan 15, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants