Fix for issue #1322 to pass no_validate #1323
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -984,11 +984,17 @@ def _progress(report): | |||
| kwargs.update({"no_validate": True}) | |||
|
|
|||
| if issu is True: | |||
| if validate is False: | |||
There was a problem hiding this comment.
Why are you explicitly setting the validate option as True always?
Are there any reference document , validation always be "True" in case of ISSU and NSSU
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sw.install parameter validate=False is not passed on to the NSSU and ISSU upgrade .
Added code to set no_validate option when validate=False