Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Apple targets for color module #143

Merged
merged 4 commits into from
Jun 20, 2022
Merged

Add Apple targets for color module #143

merged 4 commits into from
Jun 20, 2022

Conversation

Phoenix7351
Copy link
Contributor

Updating to work with Apple products.

@Phoenix7351 Phoenix7351 marked this pull request as ready for review June 16, 2022 19:30
@Phoenix7351 Phoenix7351 requested a review from a team June 16, 2022 19:30
@Phoenix7351 Phoenix7351 requested a review from sdonn3 June 16, 2022 19:30
@github-actions
Copy link

github-actions bot commented Jun 16, 2022

Unit Test Results

14 files  14 suites   12s ⏱️
45 tests 45 ✔️ 0 💤 0
90 runs  90 ✔️ 0 💤 0

Results for commit f3c497c.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Jun 16, 2022

Codecov Report

Merging #143 (f3c497c) into main (8c86321) will increase coverage by 7.87%.
The diff coverage is 72.09%.

@@             Coverage Diff              @@
##               main     #143      +/-   ##
============================================
+ Coverage     70.47%   78.35%   +7.87%     
+ Complexity       67       58       -9     
============================================
  Files            31       22       -9     
  Lines           918     1155     +237     
  Branches         83      122      +39     
============================================
+ Hits            647      905     +258     
+ Misses          236      198      -38     
- Partials         35       52      +17     
Impacted Files Coverage Δ
kanvas/src/commonMain/kotlin/svg/PathString.kt 35.71% <0.00%> (-7.88%) ⬇️
shape/src/commonMain/kotlin/curve/Linear.kt 0.00% <0.00%> (ø)
kanvas/src/commonMain/kotlin/Ellipse.kt 81.25% <25.00%> (-4.47%) ⬇️
kanvas/src/commonMain/kotlin/ReifyPath.kt 39.21% <39.21%> (ø)
kanvas/src/commonMain/kotlin/svg/StringToPath.kt 83.81% <83.81%> (ø)
...anvas/src/commonMain/kotlin/RelativePathBuilder.kt 96.15% <85.71%> (+1.15%) ⬆️
kanvas/src/commonMain/kotlin/svg/SvgKanvas.kt 60.13% <87.17%> (+9.19%) ⬆️
kanvas/src/commonMain/kotlin/svg/Paint.kt 65.51% <87.50%> (+7.37%) ⬆️
kanvas/src/commonMain/kotlin/PathBuilder.kt 100.00% <100.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3558000...f3c497c. Read the comment docs.

@cedrickcooke cedrickcooke added this to the 0.12.0 milestone Jun 17, 2022
# Conflicts:
#	color/build.gradle.kts
@cedrickcooke cedrickcooke changed the title CA-811: Adding Apple targets for iOS app Add Apple targets for color module Jun 20, 2022
@cedrickcooke cedrickcooke enabled auto-merge (squash) June 20, 2022 22:53
@cedrickcooke cedrickcooke merged commit 572a4e3 into main Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants