Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

work around Cargo bug to fix Windows build with Rust 1.71 #607

Closed
wants to merge 2 commits into from
Closed

work around Cargo bug to fix Windows build with Rust 1.71 #607

wants to merge 2 commits into from

Conversation

Be-ing
Copy link
Contributor

@Be-ing Be-ing commented Jul 14, 2023 •
edited
Loading

@Be-ing Be-ing marked this pull request as draft July 14, 2023 17:26
@Be-ing Be-ing force-pushed the windows_debugging branch 2 times, most recently from 325f117 to 28d1257 Compare July 14, 2023 18:08
@Be-ing
Copy link
Contributor Author

Be-ing commented Jul 14, 2023

--print=native-static-libs on qml-extension-plugin with Rust 1.71

Qt5Core.lib Qt5Gui.lib Qt5Qml.lib kernel32.lib advapi32.lib advapi32.lib bcrypt.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib ntdll.lib ntdll.lib ntdll.lib ntdll.lib userenv.lib ws2_32.lib ws2_32.lib ws2_32.lib ws2_32.lib ws2_32.lib ws2_32.lib ws2_32.lib ws2_32.lib ws2_32.lib ws2_32.lib ws2_32.lib ws2_32.lib ws2_32.lib ws2_32.lib ws2_32.lib ws2_32.lib ws2_32.lib ws2_32.lib ws2_32.lib ws2_32.lib ws2_32.lib ws2_32.lib ws2_32.lib ws2_32.lib ws2_32.lib kernel32.lib kernel32.lib msvcrt.lib Qt5Core.lib Qt5Gui.lib Qt5Qml.lib

Qt6Core.lib Qt6Gui.lib Qt6Qml.lib kernel32.lib advapi32.lib advapi32.lib bcrypt.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib kernel32.lib ntdll.lib ntdll.lib ntdll.lib ntdll.lib userenv.lib ws2_32.lib ws2_32.lib ws2_32.lib ws2_32.lib ws2_32.lib ws2_32.lib ws2_32.lib ws2_32.lib ws2_32.lib ws2_32.lib ws2_32.lib ws2_32.lib ws2_32.lib ws2_32.lib ws2_32.lib ws2_32.lib ws2_32.lib ws2_32.lib ws2_32.lib ws2_32.lib ws2_32.lib ws2_32.lib ws2_32.lib ws2_32.lib ws2_32.lib kernel32.lib kernel32.lib msvcrt.lib Qt6Qml.lib Qt6Core.lib Qt6Gui.lib

with Rust 1.70

Qt5Core.lib Qt5Gui.lib Qt5Qml.lib kernel32.lib advapi32.lib userenv.lib kernel32.lib kernel32.lib ws2_32.lib bcrypt.lib ntdll.lib msvcrt.lib legacy_stdio_definitions.lib

Qt6Core.lib Qt6Gui.lib Qt6Qml.lib kernel32.lib advapi32.lib userenv.lib kernel32.lib kernel32.lib ws2_32.lib bcrypt.lib ntdll.lib msvcrt.lib legacy_stdio_definitions.lib

@Be-ing Be-ing force-pushed the windows_debugging branch 2 times, most recently from c6afa5e to 79f6cbe Compare July 14, 2023 19:22
@Be-ing
Copy link
Contributor Author

Be-ing commented Jul 14, 2023 •
edited
Loading

CMake debug logs show the build failure was due to Corrosion failing to get the system libraries to link from rustc: corrosion-rs/corrosion#418

@Be-ing Be-ing force-pushed the windows_debugging branch 6 times, most recently from ddb101d to 184932e Compare July 14, 2023 21:46
@Be-ing
move build directory outside of repository
47999bf 
to hack around rust-lang/cargo#12360
and fix Windows build with Rust 1.71
@Be-ing Be-ing changed the title debug Windows build with Rust 1.71 workaround Cargo bug to fix Windows build with Rust 1.71 Jul 14, 2023
@Be-ing Be-ing marked this pull request as ready for review July 14, 2023 22:16
@Be-ing Be-ing changed the title workaround Cargo bug to fix Windows build with Rust 1.71 work around Cargo bug to fix Windows build with Rust 1.71 Jul 14, 2023
@Be-ing Be-ing mentioned this pull request Jul 14, 2023
Closed
@Be-ing Be-ing marked this pull request as draft July 15, 2023 18:46
@Be-ing
Copy link
Contributor Author

Be-ing commented Jul 15, 2023

Closing in favor of the better solution in #609

@Be-ing Be-ing closed this Jul 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Be-ing @ahayzen-kdab