Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cxx-qt-lib: use cxx_qt::bridge and #[qsignal] #840

Merged
merged 1 commit into from
Feb 21, 2024
Merged

cxx-qt-lib: use cxx_qt::bridge and #[qsignal] #840

merged 1 commit into from
Feb 21, 2024

Conversation

ahayzen-kdab
Copy link
Collaborator

@ahayzen-kdab ahayzen-kdab commented Feb 8, 2024 •
edited
Loading

Requires #837 and #843

@ahayzen-kdab ahayzen-kdab force-pushed the 319-cxx-qt-lib-use-cxx-qt branch 5 times, most recently from 4bf2676 to d1b99e3 Compare February 12, 2024 06:30
@ahayzen-kdab ahayzen-kdab changed the title WIP: cxx-qt-lib: use cxx_qt::bridge and #[qsignal] cxx-qt-lib: use cxx_qt::bridge and #[qsignal] Feb 12, 2024
@ahayzen-kdab ahayzen-kdab mentioned this pull request Feb 12, 2024
Closed
@ahayzen-kdab ahayzen-kdab force-pushed the 319-cxx-qt-lib-use-cxx-qt branch from d1b99e3 to d598063 Compare February 12, 2024 06:49
@ahayzen-kdab
cxx-qt-lib: use cxx_qt::bridge and #[qsignal] in QQmlEngine
90aee97 
This allows for us to declare a signal and listen to it.
@ahayzen-kdab ahayzen-kdab force-pushed the 319-cxx-qt-lib-use-cxx-qt branch from d598063 to 90aee97 Compare February 21, 2024 14:21
@ahayzen-kdab ahayzen-kdab marked this pull request as ready for review February 21, 2024 14:22
LeonMatthesKDAB
LeonMatthesKDAB approved these changes Feb 21, 2024
View reviewed changes
Copy link
Collaborator

@LeonMatthesKDAB LeonMatthesKDAB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for now.
We should investigate adding some kind of Inherits trait later that generalizes the concept of upcasting.

crates/cxx-qt-lib-headers/include/qml/qqmlapplicationengine.h Show resolved Hide resolved
examples/cargo_without_cmake/src/main.rs Show resolved Hide resolved
crates/cxx-qt-lib/src/qml/qqmlapplicationengine.rs Show resolved Hide resolved
@ahayzen-kdab ahayzen-kdab mentioned this pull request Feb 21, 2024
Open
6 tasks
@ahayzen-kdab ahayzen-kdab merged commit d5559cb into KDAB:main Feb 21, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeonMatthesKDAB LeonMatthesKDAB LeonMatthesKDAB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahayzen-kdab @LeonMatthesKDAB