Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/너비 하드코딩 된 부분 수정 #850 #854

Merged
merged 1 commit into from
Dec 10, 2023
Merged

Feature/너비 하드코딩 된 부분 수정 #850 #854

merged 1 commit into from
Dec 10, 2023

Conversation

publdaze
Copy link
Contributor

연관 이슈

작업 요약

  • 키퍼 테마로 커스텀된 너비들 상수로 적용해주었습니다.

작업 상세 설명

(✅는 변경 후 정상동작(색상 이상 없는 지) 확인한 사항입니다!)

  • 사이드바, 헤더, 컨테이너
    • ✅ 변경후 사이즈 변동 없음 확인하였습니다.

To 리뷰어..

  • 예상 리뷰 소요 시간 2분

@publdaze publdaze added the Refactor 리팩토링 label Dec 10, 2023
@publdaze publdaze self-assigned this Dec 10, 2023
pipisebastian
pipisebastian approved these changes Dec 10, 2023
View reviewed changes
Copy link
Member

@pipisebastian pipisebastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!!

@publdaze publdaze merged commit 0dcc062 into develop Dec 10, 2023
2 checks passed
@publdaze publdaze deleted the feature/너비_하드코딩_된_부분_수정_#850 branch December 10, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pipisebastian pipisebastian pipisebastian approved these changes

@jasper200207 jasper200207 Awaiting requested review from jasper200207

@mun-kyeong mun-kyeong Awaiting requested review from mun-kyeong

Assignees

@publdaze publdaze

Labels
Refactor 리팩토링
Projects
KEEPER FRONT R2
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

너비 하드코딩 된 부분 수정
2 participants
@publdaze @pipisebastian