Skip to content

Commit

Permalink
Merge pull request #4 from KNMI/order
Browse files Browse the repository at this point in the history
Correct order in LandingPageModel
  • Loading branch information
lukas-phaf authored Oct 30, 2023
2 parents 50d8d7f + 8957245 commit 0e76881
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 4 deletions.
4 changes: 4 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,10 @@ pytest tests/

This library is used to build an Environmental Data Retrieval (EDR) API, serving observation data from surface weather data station data from the KNMI. See the [KNMI Data Platform](https://developer.dataplatform.knmi.nl/edr-api).

## Related projects
* [CoverageJSON Pydantic](https://github.com/KNMI/covjson-pydantic)
* [geojson-pydantic](https://github.com/developmentseed/geojson-pydantic)

## TODOs
Help is wanted in the following areas to fully implement the EDR spec:
* See TODOs in code listing various small inconsistencies in the spec
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ classifiers = [
"Topic :: Scientific/Engineering :: GIS",
"Typing :: Typed",
]
version = "0.2.0"
version = "0.2.1"
dependencies = ["pydantic>=2.3,<3"]

[project.optional-dependencies]
Expand Down
2 changes: 1 addition & 1 deletion src/edr_pydantic/capabilities.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,9 @@ class Contact(EdrBaseModel):


class LandingPageModel(EdrBaseModel):
links: List[Link]
title: Optional[str] = None
description: Optional[str] = None
links: List[Link]
keywords: Optional[List[str]] = None
provider: Optional[Provider] = None
contact: Optional[Contact] = None
Expand Down
4 changes: 2 additions & 2 deletions tests/test_data/landing-page.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
{
"title": "Observations API EDR",
"description": "The observation api in EDR format from the KNMI",
"links": [
{
"href": "https://api.dataplatform.knmi.nl/edr/",
Expand Down Expand Up @@ -26,8 +28,6 @@
"title": "Collections metadata in JSON"
}
],
"title": "Observations API EDR",
"description": "The observation api in EDR format from the KNMI",
"keywords": [
"Weather",
"Temperature",
Expand Down

0 comments on commit 0e76881

Please sign in to comment.