Allow first multicast msg from unsynchronised client #764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WAvdBeek
reviewed
Feb 8, 2024
| @@ -158,9 +158,14 @@ oc_replay_check_client(uint64_t rx_ssn, oc_string_t rx_kid, | |||
| */ | |||
|
|
|||
| struct oc_replay_record *rec = get_record(rx_kid, rx_kid_ctx); | |||
| if (rec == NULL) | |||
There was a problem hiding this comment.
can we add cmake variable to enable that it always does an echo option?
tiniuclx
approved these changes
Feb 8, 2024
WAvdBeek
approved these changes
Feb 8, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From Spec:
KNX IoT devices MAY trust the first authenticated multicast message from an unsynchronized peer by default, which is configurable