feat: add CriticalAlert component (#52) #99
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jeongyong-park
requested review from
hismethod,
lukasjhan and
yunseorim1116
as code owners
Closed
lukasjhan
reviewed
Dec 28, 2024
Member
lukasjhan
left a comment
lukasjhan
left a comment
There was a problem hiding this comment.
Hi I got an error in CriticalAlert.stories.ts:4 when I start the storybook. Any idea why?
Internal server error: Failed to resolve import "@storybook/addon-viewport" from "stories/core/CriticalAlert.stories.ts". Does the file exist?
Member
|
If viewport setup in parameters is removed, then it seems okay |
Contributor
Author
I removed that. review again pls |
lukasjhan
reviewed
Dec 30, 2024
Member
lukasjhan
left a comment
lukasjhan
left a comment
There was a problem hiding this comment.
Thanks. Looks good to me, plz resolve the comment, then we could merge this.
Jeongyong-park
force-pushed
the
feat/critical-alert
branch
2 times, most recently
from
37d78de to
1547134
Compare
Signed-off-by: Jeongyong Park <kladess@gmail.com>
…viewport settings Signed-off-by: Jeongyong Park <kladess@gmail.com>
Signed-off-by: Jeongyong Park <kladess@gmail.com>
Signed-off-by: Jeongyong Park <kladess@gmail.com>
Jeongyong-park
force-pushed
the
feat/critical-alert
branch
from
1547134 to
6916a92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.