Update spinlock.hpp

KRM7 · Mar 29, 2024 · e792f9f · e792f9f
1 parent 1af9df9
commit e792f9f
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 9 deletions.
diff --git a/src/utility/shared_spinlock.hpp b/src/utility/shared_spinlock.hpp
@@ -4,13 +4,12 @@
 #define GA_UTILITY_SHARED_SPINLOCK_HPP
 
 #include "utility.hpp"
-#include "spinlock.hpp"
 #include <atomic>
-#include <thread>
-#include <tuple>
 #include <limits>
 #include <cstdint>
 
+#include "spinlock.hpp"
+
 namespace gapp::detail
 {
     class shared_spinlock
@@ -20,9 +19,8 @@ namespace gapp::detail
         {
             while (true)
             {
-                while (cntr_.load(std::memory_order_relaxed)) GAPP_PAUSE();
                 if (try_lock()) break;
-                std::this_thread::yield();
+                while (cntr_.load(std::memory_order_relaxed)) GAPP_PAUSE();
             }
         }
 
@@ -34,14 +32,16 @@ namespace gapp::detail
 
         void unlock() noexcept
         {
+            //__tsan_release(&cntr_);
             cntr_.fetch_sub(WRITER, std::memory_order_release);
         }
 
         void lock_shared() noexcept
         {
             cntr_.fetch_add(1, std::memory_order_release);
             while (cntr_.load(std::memory_order_relaxed) >= WRITER) GAPP_PAUSE();
-            std::ignore = cntr_.load(std::memory_order_acquire);
+            std::atomic_thread_fence(std::memory_order_acquire);
+            __tsan_acquire(&cntr_);
         }
 
         bool try_lock_shared() noexcept
@@ -54,6 +54,7 @@ namespace gapp::detail
 
         void unlock_shared() noexcept
         {
+            //__tsan_release(&cntr_);
             cntr_.fetch_sub(1, std::memory_order_release);
         }
 

diff --git a/src/utility/spinlock.hpp b/src/utility/spinlock.hpp
@@ -5,7 +5,13 @@
 
 #include "utility.hpp"
 #include <atomic>
-#include <thread>
+
+#if __has_feature(thread_sanitizer) && __has_include(<sanitizer/tsan_interface.h>)
+#include <sanitizer/tsan_interface.h>
+#else
+#define __tsan_acquire(...)
+#define __tsan_release(...)
+#endif
 
 namespace gapp::detail
 {
@@ -16,9 +22,13 @@ namespace gapp::detail
         {
             while (true)
             {
+                if (!locked_.test_and_set(std::memory_order_relaxed))
+                {
+                    std::atomic_thread_fence(std::memory_order_acquire);
+                    __tsan_acquire(&locked_);
+                    break;
+                }
                 while (locked_.test(std::memory_order_relaxed)) GAPP_PAUSE();
-                if (!locked_.test_and_set(std::memory_order_acquire)) break;
-                std::this_thread::yield();
             }
         }
 
@@ -30,6 +40,7 @@ namespace gapp::detail
 
         void unlock() noexcept
         {
+            //__tsan_release(&locked_);
             locked_.clear(std::memory_order_release);
         }