Yet more VSCode suggestions and eliminate all BOMs

KSP-CKAN · Oct 18, 2023 · f786791 · f786791
1 parent 5eae32b
commit f786791
Show file tree

Hide file tree

Showing 447 changed files with 460 additions and 477 deletions.
diff --git a/AutoUpdate/App.config b/AutoUpdate/App.config
@@ -1,7 +1,7 @@
-<?xml version="1.0" encoding="utf-8"?>
+<?xml version="1.0" encoding="utf-8"?>
 <configuration>
   <startup>
     <supportedRuntime version="v4.0" sku=".NETFramework,Version=v4.5" />
   </startup>
   <requestedExecutionLevel level="requireAdministrator" uiAccess="false" />
-</configuration>
+</configuration>
diff --git a/AutoUpdate/CKAN-autoupdate.csproj b/AutoUpdate/CKAN-autoupdate.csproj
@@ -1,4 +1,4 @@
-<Project>
+<Project>
   <PropertyGroup>
     <AssemblyName>CKAN-AutoUpdateHelper</AssemblyName>
     <OutputPath>..\_build\out\$(AssemblyName)\$(Configuration)\bin\</OutputPath>

diff --git a/AutoUpdate/Main.cs b/AutoUpdate/Main.cs
@@ -1,4 +1,4 @@
-using System;
+using System;
 using System.Diagnostics;
 using System.IO;
 using System.Threading;

diff --git a/AutoUpdate/Properties/AssemblyInfo.cs b/AutoUpdate/Properties/AssemblyInfo.cs
@@ -1,4 +1,4 @@
-using System.Resources;
+using System.Resources;
 using System.Reflection;
 using System.Runtime.CompilerServices;
 

diff --git a/AutoUpdate/Properties/Resources.Designer.cs b/AutoUpdate/Properties/Resources.Designer.cs
diff --git a/CKAN.sln b/CKAN.sln
@@ -1,4 +1,4 @@
-
+
 Microsoft Visual Studio Solution File, Format Version 12.00
 # Visual Studio Version 16
 VisualStudioVersion = 16.0.30225.117

diff --git a/Cmdline/Action/Compare.cs b/Cmdline/Action/Compare.cs
@@ -1,4 +1,4 @@
-using CKAN.Versioning;
+using CKAN.Versioning;
 
 namespace CKAN.CmdLine
 {

diff --git a/Cmdline/Action/ICommand.cs b/Cmdline/Action/ICommand.cs
@@ -1,4 +1,4 @@
-namespace CKAN.CmdLine
+namespace CKAN.CmdLine
 {
     public interface ICommand
     {

diff --git a/Cmdline/Action/ISubCommand.cs b/Cmdline/Action/ISubCommand.cs
@@ -1,4 +1,4 @@
-namespace CKAN.CmdLine
+namespace CKAN.CmdLine
 {
     internal interface ISubCommand
     {

diff --git a/Cmdline/CKAN-cmdline.csproj b/Cmdline/CKAN-cmdline.csproj
@@ -1,4 +1,4 @@
-<Project>
+<Project>
   <PropertyGroup>
     <AssemblyName>CKAN-CmdLine</AssemblyName>
     <OutputPath>..\_build\out\$(AssemblyName)\$(Configuration)\bin\</OutputPath>

diff --git a/Cmdline/ConsoleUser.cs b/Cmdline/ConsoleUser.cs
@@ -1,4 +1,4 @@
-using System;
+using System;
 using System.Linq;
 using System.Text.RegularExpressions;
 using log4net;

diff --git a/Cmdline/Properties/AssemblyInfo.cs b/Cmdline/Properties/AssemblyInfo.cs
@@ -1,4 +1,4 @@
-using System.Resources;
+using System.Resources;
 using System.Reflection;
 using System.Runtime.CompilerServices;
 

diff --git a/Cmdline/Properties/Resources.Designer.cs b/Cmdline/Properties/Resources.Designer.cs
diff --git a/ConsoleUI/CKAN-ConsoleUI.csproj b/ConsoleUI/CKAN-ConsoleUI.csproj
@@ -1,4 +1,4 @@
-<Project>
+<Project>
   <PropertyGroup>
     <AssemblyName>CKAN-ConsoleUI</AssemblyName>
     <OutputPath>..\_build\out\$(AssemblyName)\$(Configuration)\bin\</OutputPath>

diff --git a/ConsoleUI/Program.cs b/ConsoleUI/Program.cs
@@ -1,4 +1,4 @@
-using System;
+using System;
 
 namespace CKAN.ConsoleUI
 {

diff --git a/ConsoleUI/Properties/AssemblyInfo.cs b/ConsoleUI/Properties/AssemblyInfo.cs
@@ -1,4 +1,4 @@
-using System.Resources;
+using System.Resources;
 using System.Reflection;
 using System.Runtime.CompilerServices;
 

diff --git a/ConsoleUI/Properties/Resources.Designer.cs b/ConsoleUI/Properties/Resources.Designer.cs
diff --git a/Core/CKAN-core.csproj b/Core/CKAN-core.csproj
@@ -1,4 +1,4 @@
-<Project>
+<Project>
   <PropertyGroup>
     <AssemblyName>CKAN</AssemblyName>
     <OutputPath>..\_build\out\$(AssemblyName)\$(Configuration)\bin\</OutputPath>

diff --git a/Core/Configuration/IConfiguration.cs b/Core/Configuration/IConfiguration.cs
@@ -1,4 +1,4 @@
-using System;
+using System;
 using System.Collections.Generic;
 
 namespace CKAN.Configuration

diff --git a/Core/Converters/JsonIgnoreBadUrlConverter.cs b/Core/Converters/JsonIgnoreBadUrlConverter.cs
@@ -1,4 +1,4 @@
-using System;
+using System;
 using Newtonsoft.Json;
 using log4net;
 

diff --git a/Core/Exporters/BbCodeExporter.cs b/Core/Exporters/BbCodeExporter.cs
@@ -1,4 +1,4 @@
-using System.IO;
+using System.IO;
 using System.Linq;
 
 namespace CKAN.Exporters

diff --git a/Core/Exporters/DelimeterSeparatedValueExporter.cs b/Core/Exporters/DelimeterSeparatedValueExporter.cs
@@ -1,4 +1,4 @@
-using System;
+using System;
 using System.IO;
 using System.Linq;
 

diff --git a/Core/Exporters/Exporter.cs b/Core/Exporters/Exporter.cs
@@ -1,4 +1,4 @@
-using System;
+using System;
 using System.IO;
 using CKAN.Types;
 

diff --git a/Core/Exporters/IExporter.cs b/Core/Exporters/IExporter.cs
@@ -1,4 +1,4 @@
-using System.IO;
+using System.IO;
 
 namespace CKAN.Exporters
 {

diff --git a/Core/Exporters/MarkdownExporter.cs b/Core/Exporters/MarkdownExporter.cs
@@ -1,4 +1,4 @@
-using System.IO;
+using System.IO;
 using System.Linq;
 
 namespace CKAN.Exporters

diff --git a/Core/Exporters/PlainTextExporter.cs b/Core/Exporters/PlainTextExporter.cs
@@ -1,4 +1,4 @@
-using System.IO;
+using System.IO;
 using System.Linq;
 
 namespace CKAN.Exporters

diff --git a/Core/Games/KerbalSpaceProgram/DLC/IDlcDetector.cs b/Core/Games/KerbalSpaceProgram/DLC/IDlcDetector.cs
@@ -1,4 +1,4 @@
-using CKAN.Versioning;
+using CKAN.Versioning;
 using CKAN.Games;
 
 namespace CKAN.DLC

diff --git a/Core/Logging.cs b/Core/Logging.cs
@@ -1,4 +1,4 @@
-using System;
+using System;
 using System.IO;
 using System.Reflection;
 using System.Diagnostics;

diff --git a/Core/Meta.cs b/Core/Meta.cs
@@ -1,4 +1,4 @@
-using System;
+using System;
 using System.Linq;
 using System.Reflection;
 

diff --git a/Core/Net/AutoUpdate.cs b/Core/Net/AutoUpdate.cs
@@ -1,4 +1,4 @@
-using System;
+using System;
 using System.Collections.Generic;
 using System.IO;
 using System.Diagnostics;

diff --git a/Core/Platform.cs b/Core/Platform.cs
@@ -1,4 +1,4 @@
-using System;
+using System;
 using System.Reflection;
 using System.Runtime.InteropServices;
 using System.Text.RegularExpressions;

diff --git a/Core/Properties/AssemblyInfo.cs b/Core/Properties/AssemblyInfo.cs
@@ -1,4 +1,4 @@
-using System.Resources;
+using System.Resources;
 using System.Reflection;
 using System.Runtime.CompilerServices;
 

diff --git a/Core/Types/ExportFileType.cs b/Core/Types/ExportFileType.cs
@@ -1,4 +1,4 @@
-namespace CKAN.Types
+namespace CKAN.Types
 {
     public enum ExportFileType
     {

diff --git a/Core/Types/GameComparator/BaseGameComparator.cs b/Core/Types/GameComparator/BaseGameComparator.cs
@@ -1,4 +1,4 @@
-using CKAN.Versioning;
+using CKAN.Versioning;
 
 namespace CKAN
 {

diff --git a/Core/Types/GameComparator/GrasGameComparator.cs b/Core/Types/GameComparator/GrasGameComparator.cs
@@ -1,4 +1,4 @@
-using CKAN.Versioning;
+using CKAN.Versioning;
 
 namespace CKAN
 {

diff --git a/Core/Types/GameComparator/IGameComparator.cs b/Core/Types/GameComparator/IGameComparator.cs
@@ -1,4 +1,4 @@
-using CKAN.Versioning;
+using CKAN.Versioning;
 
 namespace CKAN
 {

diff --git a/Core/Types/GameComparator/YoyoGameComparator.cs b/Core/Types/GameComparator/YoyoGameComparator.cs
@@ -1,4 +1,4 @@
-using CKAN.Versioning;
+using CKAN.Versioning;
 
 namespace CKAN
 {

diff --git a/Core/Types/ReleaseStatus.cs b/Core/Types/ReleaseStatus.cs
@@ -1,4 +1,4 @@
-using System;
+using System;
 using System.Collections.Generic;
 
 using Newtonsoft.Json;

diff --git a/Core/VersionFormat.cs b/Core/VersionFormat.cs
@@ -1,4 +1,4 @@
-namespace CKAN
+namespace CKAN
 {
     public enum VersionFormat
     {

diff --git a/Core/Versioning/GameVersionBound.cs b/Core/Versioning/GameVersionBound.cs
@@ -1,4 +1,4 @@
-using System;
+using System;
 using System.Linq;
 
 namespace CKAN.Versioning

diff --git a/Core/Versioning/GameVersionCriteria.cs b/Core/Versioning/GameVersionCriteria.cs
@@ -1,4 +1,4 @@
-using System;
+using System;
 using System.Collections.Generic;
 using System.Linq;
 

diff --git a/GUI/ControlFactory.cs b/GUI/ControlFactory.cs
@@ -1,4 +1,4 @@
-using System.Diagnostics;
+using System.Diagnostics;
 using System.Threading;
 
 namespace CKAN.GUI

diff --git a/GUI/Controls/Changeset.resx b/GUI/Controls/Changeset.resx
@@ -1,4 +1,4 @@
-<?xml version="1.0" encoding="utf-8"?>
+<?xml version="1.0" encoding="utf-8"?>
 <root>
   <!--
     Microsoft ResX Schema

diff --git a/GUI/Controls/ChooseProvidedMods.Designer.cs b/GUI/Controls/ChooseProvidedMods.Designer.cs
diff --git a/GUI/Controls/ChooseProvidedMods.cs b/GUI/Controls/ChooseProvidedMods.cs
@@ -58,10 +58,7 @@ public ListView.SelectedListViewItemCollection SelectedItems
 
         private void ChooseProvidedModsListView_SelectedIndexChanged(object sender, EventArgs e)
         {
-            if (OnSelectedItemsChanged != null)
-            {
-                OnSelectedItemsChanged(ChooseProvidedModsListView.SelectedItems);
-            }
+            OnSelectedItemsChanged?.Invoke(ChooseProvidedModsListView.SelectedItems);
         }
 
         private void ChooseProvidedModsListView_ItemChecked(object sender, ItemCheckedEventArgs e)

diff --git a/GUI/Controls/ChooseProvidedMods.resx b/GUI/Controls/ChooseProvidedMods.resx
@@ -1,4 +1,4 @@
-<?xml version="1.0" encoding="utf-8"?>
+<?xml version="1.0" encoding="utf-8"?>
 <root>
   <!--
     Microsoft ResX Schema

diff --git a/GUI/Controls/ChooseRecommendedMods.Designer.cs b/GUI/Controls/ChooseRecommendedMods.Designer.cs
diff --git a/GUI/Controls/ChooseRecommendedMods.resx b/GUI/Controls/ChooseRecommendedMods.resx
@@ -1,4 +1,4 @@
-<?xml version="1.0" encoding="utf-8"?>
+<?xml version="1.0" encoding="utf-8"?>
 <root>
   <!--
     Microsoft ResX Schema

diff --git a/GUI/Controls/DeleteDirectories.resx b/GUI/Controls/DeleteDirectories.resx
@@ -1,4 +1,4 @@
-<?xml version="1.0" encoding="utf-8"?>
+<?xml version="1.0" encoding="utf-8"?>
 <root>
   <!--
     Microsoft ResX Schema

diff --git a/GUI/Controls/EditModSearch.Designer.cs b/GUI/Controls/EditModSearch.Designer.cs
diff --git a/GUI/Controls/EditModSearch.resx b/GUI/Controls/EditModSearch.resx
@@ -1,4 +1,4 @@
-<?xml version="1.0" encoding="utf-8"?>
+<?xml version="1.0" encoding="utf-8"?>
 <root>
   <!--
     Microsoft ResX Schema

diff --git a/GUI/Controls/EditModSearchDetails.Designer.cs b/GUI/Controls/EditModSearchDetails.Designer.cs
diff --git a/GUI/Controls/EditModSearchDetails.cs b/GUI/Controls/EditModSearchDetails.cs
@@ -1,6 +1,5 @@
 using System;
 using System.Windows.Forms;
-using log4net;
 
 namespace CKAN.GUI
 {
@@ -65,8 +64,6 @@ protected override void OnLeave(EventArgs e)
             SurrenderFocus?.Invoke();
         }
 
-        private static readonly ILog log = LogManager.GetLogger(typeof(EditModSearchDetails));
-
         private void FilterTextBox_TextChanged(object sender, EventArgs e)
         {
             ApplySearch?.Invoke(sender, e);

diff --git a/GUI/Controls/EditModSearchDetails.resx b/GUI/Controls/EditModSearchDetails.resx
@@ -1,4 +1,4 @@
-<?xml version="1.0" encoding="utf-8"?>
+<?xml version="1.0" encoding="utf-8"?>
 <root>
   <!--
     Microsoft ResX Schema

diff --git a/GUI/Controls/EditModSearches.Designer.cs b/GUI/Controls/EditModSearches.Designer.cs
diff --git a/GUI/Controls/EditModSearches.cs b/GUI/Controls/EditModSearches.cs
@@ -155,7 +155,7 @@ private void EditModSearch_SurrenderFocus()
             SurrenderFocus?.Invoke();
         }
 
-        private List<EditModSearch> editors = new List<EditModSearch>();
+        private readonly List<EditModSearch> editors = new List<EditModSearch>();
     }
 
 }
diff --git a/GUI/Controls/HintTextBox.cs b/GUI/Controls/HintTextBox.cs
@@ -1,4 +1,4 @@
-using System;
+using System;
 using System.Drawing;
 using System.Windows.Forms;
 

diff --git a/GUI/Controls/LeftRightRowPanel.cs b/GUI/Controls/LeftRightRowPanel.cs
@@ -84,7 +84,7 @@ private bool BordersVisible
             }
         }
 
-        private FlowLayoutPanel LeftPanel;
-        private FlowLayoutPanel RightPanel;
+        private readonly FlowLayoutPanel LeftPanel;
+        private readonly FlowLayoutPanel RightPanel;
     }
 }
diff --git a/GUI/Controls/ModInfoTabs/Versions.Designer.cs b/GUI/Controls/ModInfoTabs/Versions.Designer.cs
diff --git a/GUI/Controls/ModInfoTabs/Versions.resx b/GUI/Controls/ModInfoTabs/Versions.resx
@@ -1,4 +1,4 @@
-<?xml version="1.0" encoding="utf-8"?>
+<?xml version="1.0" encoding="utf-8"?>
 <root>
   <!-- 
     Microsoft ResX Schema 

diff --git a/GUI/Controls/PlayTime.Designer.cs b/GUI/Controls/PlayTime.Designer.cs
diff --git a/GUI/Controls/PlayTime.cs b/GUI/Controls/PlayTime.cs
@@ -1,4 +1,4 @@
-using System;
+using System;
 using System.Linq;
 using System.ComponentModel;
 using System.Collections.Generic;