Start installing mods while downloads are still in progress #4249
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivations
ckan available
always lists all the available mods. If you have some idea of what you're looking for (e.g., I wanted to list the "OPX" mods for testing), it would be nice to be able to apply a filter.Problems
Causes
Progress<>
objects, which run code on a thread pool and can be de-allocated before that actually happens if the task that created them finishesEditModSearches.MergeSearches
, which expects at least one element.Changes
Fixes [Feature] Install the mods while downloading others #3793.
Known issue: The internal progress bar label is not compatible with "marquee" style progress bars (where instead of reflecting a percentage completion, it just plays an animation). The label is shown for one frame of animation and then disappears. I think this is OK for now since we don't use the labels with marquee style to display actual useful information. This might be something we can address in the future with more messing around with the WinForms APIs.
Progress<>
objects are replaced withProgressImmediate<>
objects that run their callbacks right away instead of in a thread pool, so we no longer lose updatesFixes [Feature]: Show remaining download time #4160.
ResumingWebClient
's constructor accepts an optionalHashAlgorithm
parameter. If supplied, it will be used to calculate the hash of the incoming byte stream as received from the server. Upon completion, the resulting hash is propagated outwards to theNetAsyncModulesDownloader
where it is checked against the mod's hash metadata. This eliminates hashing from the download validation step (but we still need that step for a few things like checking that the file is a valid ZIP, etc.). This should speed up installs a bit.Tests are created to exercise this and catch future regressions.
Fixes [Bug]: MakingHistory recommendation halts install instead of appearing in recommendations list #4242.
Fixes [Bug]: Unhandled exception when adding 'All' to search "Sequence contains no elements" #4244.
F10
toCtrl+T
.Fixes [Feature]: Configurable keys for menu/actions in ConsoleUI #4248.
ckan available
supports a globbing pattern (meaning you can use?
and*
as wildcards) to filter the list of available mods