Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omit license and dup fields from netkans, handle GH source ZIPs #337

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

HebaruSan
Copy link
Member

Motivation

  • As of Allow licenses to be absent from netkans CKAN#4137, license is now optional in netkans and is populated from the host APIs
  • Since multi-hosted mods are processed independently and then merged together, it's not necessary to duplicate all fields
  • When the SpaceDock Adder checks a GitHub repo for a download ZIP, it only examines assets attached to a release, even though the Inflator is capable of handling releases without assets by checking the source ZIP

Changes

  • Now the SpaceDock Adder doesn't populate license
  • Now tags, depends, and install are only populated in one of the sections for multi-hosted mods
  • Now if a GitHub repo has a release but no assets, x_netkan_github.use_source_archive: true is set and the source archive is passed to the Mod Analyzer

@HebaruSan HebaruSan added Enhancement New feature or request SpaceDock Adder Receives indexing requests and generates PRs. labels Aug 25, 2024
@HebaruSan
Copy link
Member Author

The spurious SpaceWarpInfo warnings were fixed in KSP-CKAN/CKAN#4171, so this is now sensible to merge.

@HebaruSan HebaruSan merged commit 2eeb5cc into KSP-CKAN:master Sep 3, 2024
3 checks passed
@HebaruSan HebaruSan deleted the fix/dedup-netkans branch September 3, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request SpaceDock Adder Receives indexing requests and generates PRs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant