Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Scheduler parameters #349

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

HebaruSan
Copy link
Member

Motivation

This is a quick follow-up to #348, after which I was confused by this "200" because the default for the min_cpu parameter is 50:

image

Cause

Defaults for these parameters were being specified in multiple places, with different values, and only one of them was being used.

Changes

  • Now the limit parameters to can_schedule no longer have defaults, so it is much more clear that the actual defaults come from the @click.option attributes on scheduler
    • To do that, the dev parameter is now last so it can retain its default
  • Now --min-gh can be passed on the command line to specify the GitHub API rate limit threshold, with the param's previous default of 1500
  • Now --max-queued's help string describes that parameter instead of some other parameter

@HebaruSan HebaruSan added Documentation Improvements or additions to documentation Enhancement New feature or request good first issue Good for newcomers Scheduler Adds netkans to the queue to be inflated labels Oct 31, 2024
@HebaruSan HebaruSan merged commit 47341ae into KSP-CKAN:master Oct 31, 2024
3 checks passed
@HebaruSan HebaruSan deleted the fix/scheduler-params branch October 31, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation Enhancement New feature or request good first issue Good for newcomers Scheduler Adds netkans to the queue to be inflated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant