Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LessRealThanReal.netkan #8900

Merged
merged 2 commits into from
Dec 6, 2021
Merged

Update LessRealThanReal.netkan #8900

merged 2 commits into from
Dec 6, 2021

Conversation

pehvbot
Copy link
Contributor

@pehvbot pehvbot commented Dec 6, 2021

LRTR v2+ changes the dependency list and requires KSP version 1.12+. It works with RSS and KSRSS (Kerbal Sized RSS which is not currently on CKAN) so I moved RSS to 'recommends' to allow a simpler install for any KSRSS users. It now also conflicts with KerbalConstructionTime.


ckan compat add 1.10

pehvbot and others added 2 commits December 5, 2021 20:15
LRTR v2+ changes the dependency list and requires KSP version 1.12+.  It now also conflicts with KerbalConstructionTime.
@HebaruSan
Copy link
Member

What's going on with KerbalConstructionTime? It's already a dependency, but now you're bundling it? CKAN isn't supposed to install bundled dependencies, to ensure compatibility with other mods using the same dependencies.

@pehvbot
Copy link
Contributor Author

pehvbot commented Dec 6, 2021

I understand. It comes from the RP-1 fork. Really, it's a fork of a fork since it makes a number of changes to that version. LRTR 'shadows' RP-1 and while it's not as restrictive as RP-1/RO it's more of a walled garden than most mods. I'm fairly sure any mod with a KCT hard dependency would conflict in any case, or at least not play very nice together.

@HebaruSan
Copy link
Member

OK, if it's a patched version of the mod, then I guess a conflict is the best we can do, since other mods are unlikely to want to share the same patched version. Thanks for the update, merging...

@pehvbot
Copy link
Contributor Author

pehvbot commented Dec 6, 2021

Thanks! Everything looks good. Also, as a KSP player, Thanks! Your work really improves the whole gaming experience.

@HebaruSan
Copy link
Member

Consider revisiting this after #10158 is completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants