Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change GasGiantsEnhanced dep on RSS to rec #9001

Merged
merged 1 commit into from
Feb 7, 2022
Merged

Conversation

HebaruSan
Copy link
Member

@HebaruSan HebaruSan commented Feb 7, 2022

This mod can be used with either RSS or KSRSS, but currently we have it depending on RSS. If a user wants to use KSRSS instead, there's no way to not install RSS.

KSRSS is not in CKAN and is hosted on GitLab, so the best we can do is to allow RSS to be removed. So now RSS is recommended instead of a depends.

Fixes #9000.

@HebaruSan HebaruSan merged commit c7d5b55 into master Feb 7, 2022
@HebaruSan HebaruSan deleted the HebaruSan-patch-gge branch February 7, 2022 20:49
@HebaruSan
Copy link
Member Author

With KSP-CKAN/CKAN#3661 we can now consider indexing KSRSS from its GitLab hosting. I have looked for previous correspondence about this mod on GitHub, the forum, and Discord and found nothing; neither the author hoping to be added nor preferring not to, not even someone else requesting it.

The closest is this issue on the GitLab repo, which has no discussion other than the title:

https://gitlab.com/ksrss/KSRSS/-/issues/10

So effectively we would be starting from scratch in communicating here.

@HebaruSan
Copy link
Member Author

Via Discord PM, the KSRSS team is planning for CKAN support, but it's not ready yet:

image

@HebaruSan
Copy link
Member Author

Consider revisiting this after #10158 is completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change GasGiantsEnhanced Dependency
1 participant